Move runtime type generation to dedicated internal package#14589
Merged
Conversation
🦋 Changeset detectedLatest commit: 5cbc30a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
Review posted to PR #14589. Summary of what I found:
The core refactor is behavior-preserving: nodejs_compat filtering, ENOENT-tolerant caching, the spy-friendly local adapter module, and external |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
jamesopstad
force-pushed
the
james/runtime-type-generation
branch
3 times, most recently
from
6fcaf2b to
c140741
Compare
jamesopstad
changed the title
workers-devprod
requested review from
a team and
NuroDev
and removed request for
a team
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
jamesopstad
added
the
ci:no-changeset-required
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jamesopstad
force-pushed
the
james/runtime-type-generation
branch
from
ff4bce3 to
e3d79c8
Compare
jamesopstad
removed
the
ci:no-changeset-required
NuroDev
reviewed
Jul 9, 2026
Contributor
|
✅ All changesets look good |
jamesopstad
force-pushed
the
james/runtime-type-generation
branch
from
e3d79c8 to
cac25d1
Compare
NuroDev
approved these changes
Jul 9, 2026
workers-devprod
approved these changes
Jul 9, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
jamesopstad
force-pushed
the
james/runtime-type-generation
branch
from
cac25d1 to
014c7e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move runtime type generation to dedicated internal package.
This is a precursor to supporting the runtime type generation with the new config.
Note: this PR also fixes a bug where types weren't being cached when regenerated in
wrangler dev.A picture of a cute animal (not mandatory, but encouraged)